On Sun, 3 Dec 2023 10:15:41 GMT, Alan Bateman <al...@openjdk.org> wrote:
>> Markus Grönlund has updated the pull request incrementally with two >> additional commits since the last revision: >> >> - Merge branch '8211238' of github.com:mgronlun/jdk into 8211238 >> - reflection support > > src/jdk.jfr/share/classes/jdk/jfr/internal/test/DeprecatedThing.java line 90: > >> 88: public static void reflectionForRemoval() { >> 89: staticCounter++; >> 90: } > > You might want to extend the set of tests to include cases that have the > "since" element. There is a 2x2 matrix of cases to fully exercise the > parsing of the RuntimeVisibleAnnotations content. Thanks for this input, Alan. I have made the tests and cases more structured to cover this. Cheers. ------------- PR Review Comment: https://git.openjdk.org/jdk/pull/16931#discussion_r1413080638