On Wed, 6 Dec 2023 18:41:26 GMT, Vladimir Kozlov <[email protected]> wrote:
>> Srinivas Vamsi Parasa has updated the pull request incrementally with one
>> additional commit since the last revision:
>>
>> add missing header files
>
> src/hotspot/share/opto/library_call.cpp line 5393:
>
>> 5391: if (!Matcher::supports_simd_sort(bt)) {
>> 5392: return false;
>> 5393: }
>
> This check should be in `C2Compiler::is_intrinsic_supported()`
Hi Vladimir (@vnkozlov), please see the updated changes which use
`C2Compiler::is_intrinsic_supported(id, bt)`
> src/hotspot/share/opto/library_call.cpp line 5450:
>
>> 5448: if (!Matcher::supports_simd_sort(bt)) {
>> 5449: return false;
>> 5450: }
>
> Same.
Please see the updated changes which use C2Compiler::is_intrinsic_supported(id,
bt)
-------------
PR Review Comment: https://git.openjdk.org/jdk/pull/16534#discussion_r1417946689
PR Review Comment: https://git.openjdk.org/jdk/pull/16534#discussion_r1417946968
