> Please review this change to enable -Wparentheses when building HotSpot. That > warning is enabled by -Wall (which we use). That was overridden by explicitly > disabling it, because there were a number of places in HotSpot code that > triggered such warnings. Those places have all been fixed. In some cases that > made the code perhaps a little easier to read. There were also a few bugs > found and fixed by that effort. (So -Wparentheses has found existing bugs, and > may prevent future bugs.) > > Testing: mach5 tier1 and GHA sanity checks, to provide build coverage for > Oracle-supported platforms and community-supported platforms.
Kim Barrett has updated the pull request with a new target base due to a merge or a rebase. The incremental webrev excludes the unrelated changes brought in by the merge/rebase. The pull request contains two additional commits since the last revision: - Merge branch 'master' into enable-Wparentheses - remove disable of -Wparentheses ------------- Changes: - all: https://git.openjdk.org/jdk/pull/17335/files - new: https://git.openjdk.org/jdk/pull/17335/files/84c6b063..5f8700a9 Webrevs: - full: https://webrevs.openjdk.org/?repo=jdk&pr=17335&range=01 - incr: https://webrevs.openjdk.org/?repo=jdk&pr=17335&range=00-01 Stats: 6914 lines in 219 files changed: 4005 ins; 1939 del; 970 mod Patch: https://git.openjdk.org/jdk/pull/17335.diff Fetch: git fetch https://git.openjdk.org/jdk.git pull/17335/head:pull/17335 PR: https://git.openjdk.org/jdk/pull/17335
