On Fri, 12 Jan 2024 10:08:57 GMT, Magnus Ihse Bursie <i...@openjdk.org> wrote:
> From the bug report: > > jdk/.github/scripts/gen-test-results.sh is capable of capture hs_err_* file > for erroneous and failed tests. They are also exposed under tag > `<details><summary>View HotSpot error log</summary>`. > > I think we can do the same thing for replay files. A replay file is > automatically generated when compiler threads encounter a fatal error. > sometimes, we can only trigger the compilation error on GHA. attached replay > file is invaluable. > > --- > > I have not figured out how to provoke a replay file on GHA, so this is > untested, but since it is based on the hs_err logic I'm pretty confident that > it works. If it turns out to be problematic, let's fix it in a follow up. Looks good. Except that current GHA is broken, and we would want to give it as spin before integrating. I sent a note to ops@ about this yesterday, but got no reply. Maybe you can poke them a bit? The problem is the git.openjdk.java.net forwarder not working... ------------- Marked as reviewed by shade (Reviewer). PR Review: https://git.openjdk.org/jdk/pull/17392#pullrequestreview-1818036218
