On Fri, 12 Jan 2024 17:31:55 GMT, Erik Joelsson <er...@openjdk.org> wrote:
>> This PR proposes to remove the snippet files in >> `java/lang/foreign/snippet-files` from the build. > > make/modules/java.base/Java.gmk line 41: > >> 39: java/lang/classfile/snippet-files \ >> 40: java/lang/classfile/components/snippet-files \ >> 41: jdk/lang/foreign/snippet-files > > I can't find this directory in the source tree, but there is a > `src/java.base/share/classes/java/lang/foreign/snippet-files`. Is that what > you want to exclude? If possible, we should simply exclude all files in directories that have `-` (minus sign) in their name; this is the intentional design to prevent javac from compiling those classes as package names cannot include `-`. ------------- PR Review Comment: https://git.openjdk.org/jdk/pull/17403#discussion_r1451650904
