On Tue, 16 Jan 2024 19:47:47 GMT, Jonathan Gibbons <j...@openjdk.org> wrote:

>     * Medium-size suggestion/question:
>       consider init-ing `HtmlDocletWriter.tableOfContents` directly in the 
> constructor for `HtmlDocletWriter` and not in the constructors for the 
> subtypes.

I agree it would be nice, but not sure how to do it without proliferation of 
`HtmlDocletWriter` constructors and/or constructor arguments (we have 15 direct 
`HtmlDocletWriter` subclasses of which 5 have a table of contents, and they are 
using both available super-constructors).

-------------

PR Comment: https://git.openjdk.org/jdk/pull/17062#issuecomment-1898279784

Reply via email to