> In the same spirit as 
> [JDK-8318696](https://bugs.openjdk.org/browse/JDK-8318696), we should adapt 
> the AIX-specific code in hotspot so it uses the well-defined posix `<foo>` 
> functions, instead of `<foo>64`. By setting the define _LARGE_FILES, this 
> will make `<foo>` behave as `<foo>64`, just as _FILE_OFFSET_BITS=64 does on 
> gcc. (Reference: 
> https://www.ibm.com/docs/en/aix/7.1?topic=volumes-writing-programs-that-access-large-files)
> 
> In theory, it should not even be necessary to set this, since we only compile 
> for 64-bit AIX platforms, and this is only relevant on 32-bit platforms. But 
> let's add the define anyway, for good measure. It shows at least that we have 
> thought about the matter. :-)
> 
> I have not been able to test this on AIX. I hope someone with AIX access can 
> take this for a spin.
> 
> The reason I'm doing this is for 
> [JDK-8324539](https://bugs.openjdk.org/browse/JDK-8324539). After both these 
> bugs are fixed, there will be no more `<foo>64` function calls in the code 
> base.

Magnus Ihse Bursie has updated the pull request incrementally with one 
additional commit since the last revision:

  Add compile time check for _LARGE_FILES

-------------

Changes:
  - all: https://git.openjdk.org/jdk/pull/17611/files
  - new: https://git.openjdk.org/jdk/pull/17611/files/5119bdc9..3cb64b99

Webrevs:
 - full: https://webrevs.openjdk.org/?repo=jdk&pr=17611&range=02
 - incr: https://webrevs.openjdk.org/?repo=jdk&pr=17611&range=01-02

  Stats: 4 lines in 1 file changed: 4 ins; 0 del; 0 mod
  Patch: https://git.openjdk.org/jdk/pull/17611.diff
  Fetch: git fetch https://git.openjdk.org/jdk.git pull/17611/head:pull/17611

PR: https://git.openjdk.org/jdk/pull/17611

Reply via email to