> This fixes building with GCC 14:
> * Cherry-pick a fix from Harfbuzz upstream
> * Apply other `-Wcalloc-transposed-args` fixes to the JDK sources
> 
> -Wcalloc-transposed-args errors out with GCC 14 as the OpenJDK build uses
> -Werror.
> 
> The calloc prototype is:
> 
> void *calloc(size_t nmemb, size_t size);
> 
> 
> So, just swap the number of members and size arguments to match the 
> prototype, as
> we're initialising 1 struct of size `sizeof(struct ...)`. GCC then sees we're 
> not
> doing anything wrong.

Sam James has updated the pull request incrementally with one additional commit 
since the last revision:

  whitespace

-------------

Changes:
  - all: https://git.openjdk.org/jdk/pull/17506/files
  - new: https://git.openjdk.org/jdk/pull/17506/files/ef698d82..ef79e7ab

Webrevs:
 - full: https://webrevs.openjdk.org/?repo=jdk&pr=17506&range=02
 - incr: https://webrevs.openjdk.org/?repo=jdk&pr=17506&range=01-02

  Stats: 1 line in 1 file changed: 0 ins; 0 del; 1 mod
  Patch: https://git.openjdk.org/jdk/pull/17506.diff
  Fetch: git fetch https://git.openjdk.org/jdk.git pull/17506/head:pull/17506

PR: https://git.openjdk.org/jdk/pull/17506

Reply via email to