On Fri, 2 Feb 2024 09:26:28 GMT, Kim Barrett <kbarr...@openjdk.org> wrote:
>> Sam James has updated the pull request incrementally with three additional >> commits since the last revision: >> >> - fix whitespace >> - Revert "harfbuzz: Cherry-pick upstream fix for GCC 14" >> >> This reverts commit acdd606c5d818baa783c6529ea58e66a061ec64a. >> - Conditionally pass -Wno-transposed-calloc-args for bundled harfbuzz > > make/modules/java.desktop/lib/Awt2dLibraries.gmk line 514: > >> 512: HARFBUZZ_DISABLED_WARNINGS_CXX_gcc := class-memaccess noexcept-type \ >> 513: expansion-to-defined dangling-reference maybe-uninitialized \ >> 514: calloc-transposed-args > > Inconsistent indentation. Hey, you stole my line! ------------- PR Review Comment: https://git.openjdk.org/jdk/pull/17506#discussion_r1475821303
