On Fri, 2 Feb 2024 07:01:33 GMT, Sam James <d...@openjdk.org> wrote: >> Magnus Ihse Bursie has updated the pull request incrementally with one >> additional commit since the last revision: >> >> Also fix fstatvfs on AIX > > make/modules/jdk.hotspot.agent/Lib.gmk line 31: > >> 29: >> 30: ifeq ($(call isTargetOs, linux), true) >> 31: SA_CFLAGS := -D_FILE_OFFSET_BITS=64 > > We have two choices to feel a bit more comfortable: > 1) We unconditionally `static_assert` in a few places for large `off_t`, or > 2) We only do it for platforms we know definitely support F_O_B and aren't > AIX (which we've handled separately). > > Not sure that's strictly necessary though. Also, if something understands > LARGEFILE*_SOURCE, then it probably understood F_O_B, or at least has some > macro to control it. Just thinking aloud.
@thesamesam Do you want a `static_assert`? As I said, please let me know where you want to put it. I don't think it provides much, but if it makes you feel more comfortable, I'm okay with adding it. ------------- PR Review Comment: https://git.openjdk.org/jdk/pull/17538#discussion_r1480125790
