On Thu, 8 Feb 2024 07:31:15 GMT, Magnus Ihse Bursie <i...@openjdk.org> wrote:
> I don't like this approach. There must be better ways to achieve this, like > inputting the correct value as input to the action, or setting it as a global > gh variable. Where does even the `$JAVA_HOME_17_arm64` come from? Is it > provided by GH? I don't recall setting variables with that weird case style > in our GHA files. I think (as @gdams told me) these are paths to the Java installation in the Github Runners which happen to be there. I agree, to avoid the if statement, we could properly set it as input to get-jtreg. We probably could also use the setup-java action here - however, this will then lead to downloading another JDK, not sure if this is a performance concern. ------------- PR Comment: https://git.openjdk.org/jdk/pull/17756#issuecomment-1933513448
