On Tue, 23 Jan 2024 13:02:46 GMT, Pavel Rappo <pra...@openjdk.org> wrote:
>> Jonathan Gibbons has updated the pull request with a new target base due to
>> a merge or a rebase. The pull request now contains eight commits:
>>
>> - Merge with upstream/master
>> - Merge with upstream/master
>> - Merge remote-tracking branch 'upstream/master' into
>> 8298405.doclet-markdown-v3
>> - Address review comments
>> - Fix whitespace
>> - Improve handling of embedded inline taglets
>> - Customize support for Markdown headings
>> - JDK-8298405: Support Markdown in Documentation Comments
>
> src/jdk.compiler/share/classes/com/sun/tools/javac/parser/DocCommentParser.java
> line 1315:
>
>> 1313: }
>> 1314:
>> 1315: void skipLine() {
>
> Like `peekLike()`, this method also does not seem to be consistent with
> `newline` in `nextChar()`.
It's okay. You explained my confusion here:
https://github.com/openjdk/jdk/pull/16388#discussion_r1470367971
> src/jdk.compiler/share/classes/com/sun/tools/javac/parser/DocCommentParser.java
> line 1419:
>
>> 1417: LineKind peekLineKind() {
>> 1418: switch (ch) {
>> 1419: case '#', '=', '-', '+', '_', '`', '~' -> {
>
> This change is to match that of `THEMATIC_BREAK`:
> Suggestion:
>
> case '#', '=', '-', '*', '_', '`', '~' -> {
While you seem to have forgotten to change it, no tests failed, which is sad.
-------------
PR Review Comment: https://git.openjdk.org/jdk/pull/16388#discussion_r1484619952
PR Review Comment: https://git.openjdk.org/jdk/pull/16388#discussion_r1484617917
