On Thu, 18 Jan 2024 16:21:46 GMT, Julian Waters <jwat...@openjdk.org> wrote:

>> [JDK-8323008](https://bugs.openjdk.org/browse/JDK-8323008) reports unwanted 
>> autoconf flags being added to the command line, and solves the issue by 
>> filtering out the added flags by force. This is not optimal however, as 
>> doing so leaves the autoconf message that the flags were added still 
>> displaying during the configure process, which is confusing. Instead, 
>> setting a couple of fields to disable the autoconf internals responsible for 
>> the unwanted flag is a cleaner solution
>
> Julian Waters has updated the pull request incrementally with one additional 
> commit since the last revision:
> 
>   Implement custom AC_PROG_CC and AC_PROG_CXX in util.m4

I have verified that this works fine in the Oracle internal CI.

Erik's point still stands:
> I still think it would be prudent to verify this patch with all the currently 
> accepted versions of autoconf (2.69, 2.70, 2.71, 2.72).

I think the easiest way to achieve this is to checkout the autoconf at these 
versions, and build it yourself. Iirc it was quite easy to build autoconf 
(anything else would be a shame and very bad PR for the project! :-o).

I'm hoping you are willing to do this, since I believe this is a superior 
solution and I'd like to see it in mainline. (Otherwise, let me know and I'll 
try to squeeze in doing it.)

-------------

PR Comment: https://git.openjdk.org/jdk/pull/17401#issuecomment-1938730535

Reply via email to