> The file NativeCompilation.gmk is a beast. It is one of the largest in the > build system, and it is not very well organized. This makes it hard to read, > understand, debug, edit and modify, especially since IDEs have a hard time > helping out with makefiles, so you get very little overview or navigation > support. > > This patch will split up the file into several parts. The splits are somewhat > arbitrary, but tries to keep things sort of logically connected, and make the > chunks somewhat approximate equal size. > > I've gone to great pains to make sure I do not accidentally change anything. > The order for the code in each of these files are the same as in the original > NativeCompilation.gmk. I have not rearranged any code (with a few trivially > exceptions, moving some assignments to allow better grouping), and instead > preferred to split up functionality in several parts (as in > SetupBasicVariables1-3). > > Since I include the files in alphabetic order, some code will inevitable > switch places, but this should either be just defines (which are trivially > safe to move around), or it should be code that are independent of each other. > > My intention is to follow up this shuffling with more intrusive fixes, that > can e.g. reorder stuff to make for more logical grouping. But I want to do > that separately.
Magnus Ihse Bursie has updated the pull request incrementally with two additional commits since the last revision: - Remove debug code (and fix one more space) - Restore mistakenly deleted space ------------- Changes: - all: https://git.openjdk.org/jdk/pull/17849/files - new: https://git.openjdk.org/jdk/pull/17849/files/9124f2a3..439ebf20 Webrevs: - full: https://webrevs.openjdk.org/?repo=jdk&pr=17849&range=01 - incr: https://webrevs.openjdk.org/?repo=jdk&pr=17849&range=00-01 Stats: 4 lines in 1 file changed: 0 ins; 0 del; 4 mod Patch: https://git.openjdk.org/jdk/pull/17849.diff Fetch: git fetch https://git.openjdk.org/jdk.git pull/17849/head:pull/17849 PR: https://git.openjdk.org/jdk/pull/17849
