On Sun, 21 Jan 2024 16:55:45 GMT, Sam James <d...@openjdk.org> wrote:
>> This fixes building with GCC 14: >> * ~Cherry-pick a fix from Harfbuzz upstream~ >> * Apply other `-Wcalloc-transposed-args` fixes to the JDK sources >> >> -Wcalloc-transposed-args errors out with GCC 14 as the OpenJDK build uses >> -Werror. >> >> The calloc prototype is: >> >> void *calloc(size_t nmemb, size_t size); >> >> >> So, just swap the number of members and size arguments to match the >> prototype, as >> we're initialising 1 struct of size `sizeof(struct ...)`. GCC then sees >> we're not >> doing anything wrong. > > Ah, yes! FWIW, I'm still disappointed about that as well (I don't have any > sort of power, just tend to do a lot of triage). Do consider sending it again > when stage 1 opens again after GCC 14 is out. Persistence is key with GCC, > even if your change isn't an objectionable one. It took me a little while to > get used to that.. @thesamesam you need to fix the PR title to match the JBS issue just as the bot is instructing you. Then the bots should mark this "ready" to push. ------------- PR Comment: https://git.openjdk.org/jdk/pull/17506#issuecomment-1958137002
