On Fri, 23 Feb 2024 08:18:17 GMT, Daniel Jeliński <djelin...@openjdk.org> wrote:
>> Magnus Ihse Bursie has updated the pull request incrementally with one >> additional commit since the last revision: >> >> Use #pragma instead of HIDDEN define > > src/hotspot/share/oops/accessBackend.cpp line 40: > >> 38: #if defined(TARGET_COMPILER_gcc) >> 39: // Needed to work around bug in gcc causing these symbols to be visible >> despite -fvisibility=hidden >> 40: #pragma GCC visibility push(hidden) > > does it work for you? because it doesn't hide the arraycopy symbols for me. > The explicit visibility(hidden) attribute did work. You are absolutely correct. I thought I checked that it did work, but I must have messed up somehow, because now that I retest, I see that it did not have any effect. I'm reverting that change. Thanks for being attentive! (Presumably, gcc already knew that it where compiling with visibility hidden, so the pragma did nothing, in contrast with the explicit attribute on individual functions.) ------------- PR Review Comment: https://git.openjdk.org/jdk/pull/17955#discussion_r1500596597
