On Fri, 23 Feb 2024 16:24:48 GMT, Magnus Ihse Bursie <i...@openjdk.org> wrote:
> There is not much overlap on how linking is done on Windows on one hand, and > on all Unix platforms on the other. This makes Link.gmk basically consists of > two parts, each in it own half of if statements, and the few common parts are > artificially shoehorned in to fit both sides. > > The code will be much clearer if we just split this into two different files. > > Note that this PR slightly collides with JDK-8326583 > (https://github.com/openjdk/jdk/pull/17986). Whichever of this goes in first > will mean that the other one needs to make some adaptations. I have verified that there is no differences in the resulting output using COMPARE_BUILD, for the platforms in Oracle's CI: windows-x64,linux-x64,linux-aarch64,macosx-x64,macosx-aarch64, confirming that this is a pure build system refactoring. ------------- PR Comment: https://git.openjdk.org/jdk/pull/17987#issuecomment-1962011909