On Tue, 27 Feb 2024 11:01:03 GMT, Magnus Ihse Bursie <i...@openjdk.org> wrote:
>> Once [JDK-8017234](https://bugs.openjdk.org/browse/JDK-8017234) has been >> integrated, it is possible to do some cleanup. The goal of >> [JDK-8017234](https://bugs.openjdk.org/browse/JDK-8017234) was to not change >> any behavior, even if that behavior seemed odd. >> >> Now let's try to fix that. We can: >> >> a) remove JNIEXPORT from c2v functions. >> b) make debug.cpp functions exported similarly on all platforms. >> c) remove JNIEXPORT from aarch64 asm debug function. >> >> Note that this PR is [dependent >> on](https://mail.openjdk.org/pipermail/jdk-dev/2021-March/005232.html) >> https://github.com/openjdk/jdk/pull/17955. > > Magnus Ihse Bursie has updated the pull request with a new target base due to > a merge or a rebase. The pull request now contains 10 commits: > > - Merge branch 'master' into hotspot-symbols-followup > - Remove jvmci globals > - 8326509: Clean up JNIEXPORT in Hotspot after JDK-8017234 > - Revert "Use #pragma instead of HIDDEN define" > > This reverts commit 00e40a7f6e4cdef6592d72b3d08063cdcc41532a. > - Use #pragma instead of HIDDEN define > - Rename the version script to version-script.txt > - Restore linker script to linux/gcc builds > - Rename the Windows export file to .def > - Remove unused symbol _Copy_conjoint_bytes on linux/arm32 > - 8017234: Hotspot should stop using mapfiles There was a bit back and forth with this PR, but now I believe it is finally ready. Any reviewers? ------------- PR Comment: https://git.openjdk.org/jdk/pull/17967#issuecomment-1967657651
