On Wed, 28 Feb 2024 13:12:14 GMT, Julian Waters <jwat...@openjdk.org> wrote:
>> We have seen a build failure along the lines of: >> >> /usr/bin/mv: cannot move >> '.../build/windows-x64-open-debug/hotspot/variant-server/libjvm/win-exports.def.tmp' >> to >> '.../build/windows-x64-open-debug/hotspot/variant-server/libjvm/win-exports.def': >> No such file or directory >> >> on Windows. >> >> My guess is that this is a race between creating the win-export.def file for >> the gtest jvm and the product jvm. > > make/hotspot/lib/CompileJvm.gmk line 151: > >> 149: WIN_EXPORT_FILE := $(JVM_OUTPUTDIR)/win-exports.def >> 150: >> 151: JVM_LDFLAGS_NO_GTEST += -def:$(WIN_EXPORT_FILE) > > Can't this just be named EXPORT_FILE_FLAG or something along those lines? > LDFLAGS_NO_GTEST seems a bit strange The thought was to clearly communicate why this must not be included in the gtest LDFLAGS; otherwise they must be exactly identical. ------------- PR Review Comment: https://git.openjdk.org/jdk/pull/18043#discussion_r1506012594
