On Thu, 15 Feb 2024 11:10:32 GMT, Joachim Kern <jk...@openjdk.org> wrote:

> > What does this mean? That you are not using xlc at all? Or is it clang but 
> > still with an xlc frontend, so all xlc flags etc need to stay?
> 
> The `xlc` toolchain is for the compiler versions up to 16 (xlclang++); the 
> `clang` toolchain is for the compiler versions 17 (ibm-clang++_r) and higher. 
> For the 17 Compiler the frontend is `clang`-ish and we are using the `clang` 
> flags instead of the `xlc` flags. `toolchain.m4` decides on the basis of the 
> found compiler which toolchain to use as default.
> 
> ```
> # On AIX the default toolchain depends on the installed (found) compiler
>   #   xlclang++     -> xlc toolchain
>   #   ibm-clang++_r -> clang toolchain
>   # The compiler is searched on the PATH and TOOLCHAIN_PATH
>   # xlclang++ has precedence over ibm-clang++_r if both are installed
> ```
> 
> So, if we set the minimum compiler level for AIX to 17, we can remove the xlc 
> toolchain at all. We cannot remove every reference to xlc, because at least 
> some headers we still use the xlc version (globalDefinitions_xlc.hpp)

This suggests there might be more that needs to be done here than simply
updating TOOLCHAIN_MINIMUM_VERSION_xlc.  I spent some time looking at the
relevant code, but keep getting lost in the distinction between xlc and clang.
Does updating that variable as proposed even work at all?

I'm going to need some help from you aix-ppc maintainer folks.

-------------

PR Comment: https://git.openjdk.org/jdk/pull/17857#issuecomment-1978227259

Reply via email to