On Tue, 5 Mar 2024 12:44:10 GMT, Jan Lahoda <jlah...@openjdk.org> wrote:
>> Currently, JDK modules load by the bootstrap and platform ClassLoaders are
>> automatically granted the native access. I am working on an upgrade of JLine
>> inside the `jdk.internal.le` module, and I would like to replace the current
>> native bindings with FFM-based bindings (which are now somewhat provided by
>> JLine). But, for that, native access is needed for the `jdk.internal.le`
>> module. We could possibly move the module to the platform ClassLoader, but
>> it seems it might be better to have more control over which modules have the
>> native access.
>>
>> This patch introduces an explicit list of modules that will automatically be
>> granted the native access. Note this patch is not yet intended to change the
>> end behavior - the list of modules granted native access is supposed to be
>> the same as modules in the boot and platform ClassLoaders.
>
> Jan Lahoda has updated the pull request incrementally with one additional
> commit since the last revision:
>
> Apply suggestions from code review
>
> Co-authored-by: ExE Boss <3889017+exe-b...@users.noreply.github.com>
> Co-authored-by: Maurizio Cimadamore
> <54672762+mcimadam...@users.noreply.github.com>
make/conf/module-loader-map.conf line 95:
> 93: #
> 94:
> 95: NATIVE_ACCESS_MODULES= \
Hello Jan, does this make configuration allow for something like:
NATIVE_ACCESS_MODULES= ${BOOT_MODULES} \
${PLATFORM_MODULES} \
foo.bar.additional.module
(please ignore any syntax issues in that snippet)
to make the intention clear as well as reduce the chances of missing some boot
or platform module in this NATIVE_ACCESS_MODULES?
-------------
PR Review Comment: https://git.openjdk.org/jdk/pull/18106#discussion_r1512845758
