On Wed, 6 Mar 2024 15:24:59 GMT, Andrew John Hughes <and...@openjdk.org> wrote:
>> I'm fine with this change. I wasn't around when this was introduced, but my >> guess is that it was relevant back when Hotspot and the rest of the JDK were >> often built separately. We have the username in the default $OPT string for >> personal builds, so the HOTSPOT_BUILD_USER is just redundant information. >> There is no reason to have the build user recorded in non personal builds. > >> I'm fine with this change. I wasn't around when this was introduced, but my >> guess is that it was relevant back when Hotspot and the rest of the JDK were >> often built separately. We have the username in the default $OPT string for >> personal builds, so the HOTSPOT_BUILD_USER is just redundant information. >> There is no reason to have the build user recorded in non personal builds. > > Thanks Erik. I'll leave this open a little longer for others to comment, but > I also can't see a reason why this would be needed, especially in > non-personal builds. @gnu-andrew You might also want to draw specific attention to this change on hotspot-dev, to reach all developers who might know or care about the user name. It is worth making sure to point out that the big change here is that the hotspot version string format changes; that worries me more than the removal of the user name. (In fact, a safer change might be to hardcode the user name to a dummy value like `openjdk`). ------------- PR Comment: https://git.openjdk.org/jdk/pull/18136#issuecomment-1981393909
