This Message Is From an External Sender
This message came from outside your organization.
On Fri, 8 Mar 2024 16:51:11 GMT, Magnus Ihse Bursie <i...@openjdk.org> wrote:
>> Severin Gehwolf has updated the pull request incrementally with one additional commit since the last revision: >> >> Only show runtime image suffix for JDK modules > > make/Images.gmk line 144: > >> 142: OUTPUT_DIR := $(JDK_IMAGE_DIR), \ >> 143: SUPPORT_DIR := $(JDK_RUN_TIME_IMAGE_SUPPORT_DIR), \ >> 144: PRE_COMMAND := $(RM) -r $(JDK_IMAGE_DIR), \ > > This looks scary! Why the rm? Are you sure you are not racing with some other rule that tries to read from the JDK_IMAGE_DIR? That was modelled similar to `jdk_jlink` target. It also does the removal. When building with `--enable-runtime-link-image`, the flow is: 1. Link the initial jdk image (current `images/jdk`). Output is $(RL_INTERMEDIATE_IMAGE_DIR) 2. Generate the diff to the packaged modules (target `generate_jimage_diff`) 3. Do the final link creating a runtime linkable jimage with `--create-linkabel-runtime` into `JDK_IMAGE_DIR`. All three steps should have appropriate dependencies on each other. So I don't think there is a race. If you see one please let me know! Thanks. ------------- PR Review Comment: https://git.openjdk.org/jdk/pull/14787#discussion_r1518046993
