On Tue, 12 Mar 2024 23:44:45 GMT, Magnus Ihse Bursie <[email protected]> wrote:
>> Chad Rakoczy has updated the pull request incrementally with two additional
>> commits since the last revision:
>>
>> - Print to stdout instead of stderr
>> - Compare version using VERSION_STRING
>
> make/modules/java.base/Launcher.gmk line 81:
>
>> 79: SRC := $(TOPDIR)/src/$(MODULE)/unix/native/jspawnhelper, \
>> 80: OPTIMIZATION := LOW, \
>> 81: CFLAGS := $(CFLAGS_JDKEXE) \
>
> There is no need to introduce a break after `$(CFLAGS_JDKEXE)`, for thing
> like flags we try to fill the line.
> Also, the indentation rules are that a broken line should be indented with
> four spaces. See e.g. the CFLAGS line below in CoreLibraries.gmk.
My fault, I suggested Chad to do this. So what's the preferred formatting here?
Like BUILD_JEXEC block above does it?
CFLAGS := $(CFLAGS_JDKEXE) $(VERSION_CFLAGS) \
-I$(TOPDIR)/src/$(MODULE)/unix/native/libjava, \
-------------
PR Review Comment: https://git.openjdk.org/jdk/pull/18204#discussion_r1522886607
