On Thu, 14 Mar 2024 08:48:11 GMT, Hamlin Li <m...@openjdk.org> wrote:
> Hi, > Can you help to review this patch? > Thanks > > This is a continuation of work based on [1] by @XiaohongGong, most work was > done in that pr. In this new pr, just rebased the code in [1], then added > some minor changes (renaming of calling method, add libsleef as extra lib in > CI cross-build on aarch64 in github workflow); I aslo tested the combination > of following scenarios: > * at build time > * with/without sleef > * with/without sve support > * at runtime > * with/without sleef > * with/without sve support > > [1] https://github.com/openjdk/jdk/pull/16234 > > ## Regression Test > * test/jdk/jdk/incubator/vector/ > * test/hotspot/jtreg/compiler/vectorapi/ > > ## Performance Test > Previously, @XiaohongGong has shared the data: > https://github.com/openjdk/jdk/pull/16234#issuecomment-1767727028 Changes requested by luhenry (Committer). .github/workflows/build-cross-compile.yml line 138: > 136: --arch=${{ matrix.debian-arch }} > 137: --verbose > 138: > --include=fakeroot,symlinks,build-essential,libx11-dev,libxext-dev,libxrender-dev,libxrandr-dev,libxtst-dev,libxt-dev,libcups2-dev,libfontconfig1-dev,libasound2-dev,libfreetype-dev,libpng-dev,${{ > extra-libs }} This will have to be `${{ matrix.extra-libs }}` ------------- PR Review: https://git.openjdk.org/jdk/pull/18294#pullrequestreview-1936078175 PR Review Comment: https://git.openjdk.org/jdk/pull/18294#discussion_r1524483909
