On Thu, 14 Mar 2024 12:36:05 GMT, Magnus Ihse Bursie <i...@openjdk.org> wrote:
> We are setting one of the flags `CFLAGS_JDKLIB`, `CXXFLAGS_JDKLIB`, > `CFLAGS_JDKEXE` or `CXXFLAGS_JDKEXE` to `CFLAGS` or `CXXFLAGS`, respectively, > in basically all calls to `SetupJdkLibrary` and `SetupJdkExecutable`. > > These flag variables contain a lot of duplication. > > The first step towards bringing some sanity to this mess is to move the > setting of these variables into `SetupJdkLibrary/SetupJdkExecutable`. > > In a few places these standard flags are not set, partially or fullly. This > is handled by the new arguments `DEFAULT_CFLAGS := false` (to disable the > entire setting) and `C[XX]FLAGS_FILTER_OUT` (which excludes some specific > flag) to `SetupJdkLibrary/SetupJdkExecutable`. This pull request has now been integrated. Changeset: bfba4894 Author: Magnus Ihse Bursie <i...@openjdk.org> URL: https://git.openjdk.org/jdk/commit/bfba4894e14c9547735a6b4ae73ed423af09f0d4 Stats: 168 lines in 31 files changed: 25 ins; 66 del; 77 mod 8328157: Move C[XX]FLAGS_JDK[LIB/EXE] to JdkNativeCompilation.gmk Reviewed-by: erikj ------------- PR: https://git.openjdk.org/jdk/pull/18301
