On Sun, 21 Jan 2024 19:50:16 GMT, Phil Race <p...@openjdk.org> wrote:
>> Fixed the formatting (at least in the marked cases), but am unsure what you >> mean by set directly? > >> Fixed the formatting (at least in the marked cases), but am unsure what you >> mean by set directly? > > See my comment > "like in my recoded case above, we no longer need the "pData" var which was > there only because that name > is magically known to the macro." > > so skip (and get rid of) the pData var and just set the target var directly @prrace Sorry for the page, but as I mentioned above I don't see much of an advantage to removing pData, since it appears we still have to do the null check anyway even without it. I'm also not sure what the incorrect code you mentioned above is ------------- PR Comment: https://git.openjdk.org/jdk/pull/15096#issuecomment-2014317099
