> This is the first step of several, in which I will clean up the native > compilation code as used by modules. In this first step `java.base`, > `java.deskop`, `jdk.accessibility` and `jdk.jpackage` are left out, since > they require more work. The changes in the remaining modules are trivial by > comparison. > > The changes done here are: > > 1) A new argument `JDK_LIB` has been introduced, that is used for linking > with other libraries produced by the JDK build. As a follow-up, this will be > further cleaned up and generalized, but the goal for this change is just to > separate them out from external libraries. > > 2) The list of libraries given to `LIB` and `JDK_LIB` has been sorted in > alphabetical order. Note that this change will affect the resulting binaries > (since the order libraries are given are stored in the binary), but this > change should only be superficial. (If we have symbol clashes between > libraries, then we have problems on a whole other level...). > > 3) The code has been checked for inconsistencies and style guide errors, and > a common programming style has been applied to all `Lib.gmk` and > `Launcher.gmk` files, making sure that all parts follow best practices. > > This PR will be followed up by invidual PRs for the modules requiring not > jsut trivial cleanup (`java.base`, `java.deskop`, `jdk.accessibility` and > `jdk.jpackage`), and a PR which will unify `JDK_LIB` handling across > platforms, and automatically apply proper dependencies.
Magnus Ihse Bursie has updated the pull request incrementally with one additional commit since the last revision: Fix indentation ------------- Changes: - all: https://git.openjdk.org/jdk/pull/18430/files - new: https://git.openjdk.org/jdk/pull/18430/files/b26b59f1..f68c4a29 Webrevs: - full: https://webrevs.openjdk.org/?repo=jdk&pr=18430&range=01 - incr: https://webrevs.openjdk.org/?repo=jdk&pr=18430&range=00-01 Stats: 7 lines in 3 files changed: 0 ins; 0 del; 7 mod Patch: https://git.openjdk.org/jdk/pull/18430.diff Fetch: git fetch https://git.openjdk.org/jdk.git pull/18430/head:pull/18430 PR: https://git.openjdk.org/jdk/pull/18430
