On Fri, 22 Mar 2024 17:09:16 GMT, Magnus Ihse Bursie <i...@openjdk.org> wrote:
> This is a follow-up on > [JDK-8328680](https://bugs.openjdk.org/browse/JDK-8328680), making the same > kind of cleanup to java.base. Some code needed more special treatment here, > so there is some additional effects outside of the modules/java.base > directory. I can confirm that COMPARE_BUILD only sees changed files in java.base. Once again, as far as I can tell, the changes are all related to the reordering of libraries to link with. make/common/JdkNativeCompilation.gmk line 269: > 267: endif > 268: > 269: ifeq ($$($1_SRC), ) General note: There amount of duplication between SetupJdkLibrary and SetupJdkExecutable is quickly becoming staggering... When I'm done with this cleanup, I'll unify them. ------------- PR Comment: https://git.openjdk.org/jdk/pull/18457#issuecomment-2016208913 PR Review Comment: https://git.openjdk.org/jdk/pull/18457#discussion_r1535919753
