On Tue, 26 Mar 2024 00:17:56 GMT, Julian Waters <jwat...@openjdk.org> wrote:
>> We should set the -permissive- flag for the Microsoft Visual C compiler, as >> was requested by the now backed out >> [JDK-8241499](https://bugs.openjdk.org/browse/JDK-8241499). Doing so makes >> the Visual C compiler much less accepting of ill formed code, which will >> improve code quality on Windows in the future. > > Julian Waters has updated the pull request incrementally with one additional > commit since the last revision: > > Revert formatting change in > src/java.desktop/windows/native/libawt/windows/awt_PrintJob.cpp > > Co-authored-by: Magnus Ihse Bursie <m...@icus.se> src/java.desktop/windows/native/libawt/windows/awt_Canvas.cpp line 230: > 228: } > 229: > 230: AwtCanvas *c = (AwtCanvas*) pData; Suggestion: AwtCanvas *c = (AwtCanvas*)pData; ------------- PR Review Comment: https://git.openjdk.org/jdk/pull/15096#discussion_r1538714268
