On Tue, 26 Mar 2024 19:30:01 GMT, Magnus Ihse Bursie <i...@openjdk.org> wrote:

> On AIX, we need a static libjli, since the linker cannot find other libraries 
> (like libjvm.so and libjava.so) using a relative path, as on other platforms.
> 
> However, for reasons unclear, we still build a dynamic libjli.so on AIX, even 
> though this is never used. Instead, we also build a static libjli_static.a 
> library (which is then forced to have a different name as to not collide with 
> the dynamic library).
> 
> This should be fixed. We should build exactly one libjli on all platforms, be 
> it static or dynamic.

@MBaesken @RealCLanger I will need your assistance for testing this on AIX. 

I believe all refactorings I have done will keep the static jli build identical 
on AIX (apart from the name, of course). I have searched for jli references in 
the code base to verify that there is indeed no use of the dynamic jli on AIX. 
And finally I have temporarily changed the if to allow building of a static 
library on my mac, and it seems to work fine. 

But in the end of the day it needs to be confirmed to work on AIX as well. 

For your information: My plan for going forward is to improve handling of 
static vs dynamic libraries. This will allow us to remove the special checks 
for AIX when setting up dependencies for libjli from other places. So it is 
going to get even better in the future. :-)

-------------

PR Comment: https://git.openjdk.org/jdk/pull/18497#issuecomment-2021334572

Reply via email to