On Tue, 26 Mar 2024 21:44:12 GMT, Erik Joelsson <er...@openjdk.org> wrote:
>> This is a follow-up on JDK-8328680, making the same kind of cleanup to >> jdk.jpackage. The code here needed more work than for the other modules, so >> I wanted have it in a separate PR to get a more thorough review. > > make/common/JdkNativeCompilation.gmk line 294: > >> 292: $$($1_EXTRA_RCFLAGS) >> 293: >> 294: ifneq ($$($1_HEADERS_FROM_SRC), false) > > I note that this parameter in SetupJdkLibrary is documented in the comment > above the definition, but you haven't added any of the new parameters to > SetupJdkExecutable to the comment for that macro. Should we, or is the > intention to rework this file anyway? The intention is to unify SetupJdkLibrary and SetupJdkExecutable, and clean up this file at the same time. I have tried to keep it up to date meanwhile, but I have missed it here. So for me it's either or; I can fix it now, or later. ------------- PR Review Comment: https://git.openjdk.org/jdk/pull/18491#discussion_r1540205036
