On Thu, 28 Mar 2024 07:36:04 GMT, Julian Waters <jwat...@openjdk.org> wrote:
>> We should set the -permissive- flag for the Microsoft Visual C compiler, as >> was requested by the now backed out >> [JDK-8241499](https://bugs.openjdk.org/browse/JDK-8241499). Doing so makes >> the Visual C compiler much less accepting of ill formed code, which will >> improve code quality on Windows in the future. > > Julian Waters has updated the pull request incrementally with four additional > commits since the last revision: > > - Labels to empty line in awt_Window.cpp > - Labels to empty line in awt_Window.cpp > - Label to empty line in awt_Window.cpp > - Label to empty line in awt_Window.cpp I've been monitoring it but saw no reason to pay particular attention until everything I raised is addressed. Including the cases identical to the ones I explicitly identified (which I suppose is what is meant by your question "should I do the unmarked ones too ?"). At some point you do tire of typing "ditto" :-) It has been long enough that I will need a little time to remember and re-review properly once the requested changes are in place. ------------- PR Comment: https://git.openjdk.org/jdk/pull/15096#issuecomment-2031068525
