On Thu, 21 Mar 2024 06:58:43 GMT, Robbin Ehn <r...@openjdk.org> wrote:
>> Hi, please consider. >> >> [8327045](https://bugs.openjdk.org/browse/JDK-8327045) hide these symbols. >> Tested with gcc and clang, and llvm and binutils backend. >> >> I didn't find any use of the "DLL_ENTRY", so I removed it. >> >> Thanks, Robbin > > Robbin Ehn has updated the pull request incrementally with one additional > commit since the last revision: > > remove swap file Ideally, it should just be enough to add `#import "jni.h"`. This will definitely work for capstone and llvm. However, for binutils we disable our standard C include paths, so this will fail. (I'm not sure if this is really necessary, but that is how we currently do it) To solve it you can either set `HSDIS_TOOLCHAIN_DEFAULT_CFLAGS` to `true` for binutils, or you can add the include path to jni.h directly. The former would be the best, but in case that does not work, try adding `java.base:include` to `EXTRA_HEADER_DIRS`. I apologize for the late reply. I've been just working spotty hours due to spring break. ------------- PR Comment: https://git.openjdk.org/jdk/pull/18400#issuecomment-2037695449 PR Comment: https://git.openjdk.org/jdk/pull/18400#issuecomment-2037696471
