On Tue, 9 Apr 2024 16:59:39 GMT, Thomas Stuefe <stu...@openjdk.org> wrote:
>> Hi Thomas, `maxDisclaimSize` is of type `unsigned int`; therefore I get the >> following warning: >> >> os/aix/os_aix.cpp:314:42: error: format specifies type 'unsigned long' but >> the argument has type 'unsigned int' [-Werror,-Wformat] >> RANGEFMTARGS(p, maxDisclaimSize), >> ^~~~~~~~~~~~~~~ >> >> Should I keep the casts, or change the type of `maxDisclaimSize, >> numFullDisclaimsNeeded, lastDisclaimSize` to `const unsigned long`? > > I would change them to size_t. Thanks for doing this. Done ------------- PR Review Comment: https://git.openjdk.org/jdk/pull/18536#discussion_r1559121239
