On Wed, 10 Apr 2024 10:00:02 GMT, Martin Doerr <mdo...@openjdk.org> wrote:
>> If I omit this #include <alloca.h> >> I get compiler errors of the following kind >> >> .../src/hotspot/share/runtime/javaThread.cpp:2222:24: error: use of >> undeclared identifier 'alloca' >> char* p1 = (char*) alloca(1); >> ^ >> >> >> Of course I can do this include in every nagging file, but I thought it is >> simpler to keep it in the central header. > > Is the comment in front of > https://github.com/openjdk/jdk/blob/51ed69a586105b707ae616f9eba898449bf9fba7/src/hotspot/os/aix/os_aix.cpp#L28 > still correct? Seems like it should get replaced. See > https://www.ibm.com/docs/en/openxl-c-and-cpp-aix/17.1.1?topic=pragmas-pragma-alloca-c-only Can `-Dalloca=__builtin_alloca` replace `#include <alloca.h>`? ------------- PR Review Comment: https://git.openjdk.org/jdk/pull/18536#discussion_r1559183757
