On Wed, 8 May 2024 14:29:18 GMT, Erik Joelsson <er...@openjdk.org> wrote:

>> For c, c++  and java source files, we have a built in system for letting 
>> more specific files override if there are multiple files with the same name 
>> found, by letting the first found file with a given name override any later 
>> found files with that name. This is typically used for OS specific variants 
>> or when needing to override a source file with a file from a custom source 
>> set. We would like to make it possible to do the same for markdown files 
>> used to generate man pages.
>> 
>> This will not have an immediate use i OpenJDK, but is needed for a custom 
>> override in proprietary code.
>> 
>> The change in Docs.gmk removes unnecessary extra loops so that 
>> SetupProcessMarkdown is called only once per module. This is necessary for 
>> the override mechanism to kick in for each module src set.
>> 
>> The logic in ProcessMarkdown.gmk is more or less copied from 
>> SetupNativeCompilation.
>
> Erik Joelsson has updated the pull request with a new target base due to a 
> merge or a rebase. The incremental webrev excludes the unrelated changes 
> brought in by the merge/rebase. The pull request contains three additional 
> commits since the last revision:
> 
>  - Remove debug printing
>  - Merge branch 'master' into JDK-8331886-override-markdown
>  - JDK-8331886

Marked as reviewed by ihse (Reviewer).

-------------

PR Review: https://git.openjdk.org/jdk/pull/19132#pullrequestreview-2045917930

Reply via email to