On Thu, 9 May 2024 05:04:47 GMT, Thomas Stuefe <stu...@openjdk.org> wrote:
>> On Linux aarch64, a JVM may encounter three different page sizes: 4K, 64K, >> and (when run on Mac M1 hardware) 16K. >> >> Since forgetting to specify `--enable-compatible-cds-alignment` is a common >> error that is only noticed when running the produced JVM on hardware with >> different page size, we propose to enable that option by default on Linux >> aarch64. The cost is a moderate increase in CDS archive size (about 300K). >> >> I tested this patch on: >> - x64 Linux >> - x64 Linux, crossbuilding to aarch64 >> - building natively on aarch64 Linux > > Does anyone else have an opinion on this matter? The question is: > > "Should we enable cds-compatible alignment in the configure options by > default generally, not only for Linux aarch64" ? > > This would, in addition to the proposed change affecting Linux on aarch64, > also affect MacOS x64. JVMs built there would be able to run, by default, in > Rosetta. At the price of sligthly increased archive size of a dozen KB or so. > > If nobody objects, I will do that since I like the simplicity of it. > @tstuefe We already have an issue to reset the default to true (raised by > @iklam) > > https://bugs.openjdk.org/browse/JDK-8331952 Okay. I see it was created yesterday evening. @iklam how do you want to handle this? Do you want to proceed with 8331952 and I close this as duplicate? Or vice versa? ------------- PR Comment: https://git.openjdk.org/jdk/pull/19142#issuecomment-2102339405
