Hi Johan,
On 21/05/2024 7:32 pm, Johan Vos wrote:
Hi,
While working on OpenJDK/Mobile, I had to apply a patch for Android and
iOS that I believe might be broader than just the mobile platforms.
I had compile issues in
stubGenerator_aarch64.cpp:8470:13: error: use of undeclared identifier
'InlineSecondarySupersTest'
I noticed that InlineSecondarySupersTest is only added
via c2_globals.hpp . In my branch for the mobile port, I added a check
around that code [1] and now it works when I want to build a minimal or
a client variant. However, when I use the same configuration on Linux or
MacOSX (--with-jvm-variants=client or minimal), it fails on those
platforms as well (it works fine on the server variant, as that grabs
c2_globals.hpp).
Is this a more generic issue than just mobile?
Yes I think so, but not a build-dev issue :)
It was introduced by JDK-8180450: secondary_super_cache does not scale
well back on April 16. It should be in
#ifdef COMPILER2
as per ./hotspot/cpu/x86/stubGenerator_x86_64.cpp
Cheers,
David
Thanks,
- Johan
[1]
https://github.com/openjdk/jdk/commit/47377a2ad398eadd7acb8cccf1e95703c76328fe#diff-9112056f732229b18fec48fb0b20a3fe824de49d0abd41fbdb4202cfe70ad114R8468 <https://github.com/openjdk/jdk/commit/47377a2ad398eadd7acb8cccf1e95703c76328fe#diff-9112056f732229b18fec48fb0b20a3fe824de49d0abd41fbdb4202cfe70ad114R8468>
