On Tue, 11 Jun 2024 14:46:10 GMT, Matthias Baesken <mbaes...@openjdk.org> wrote:
> My maximum JfrEventId is 163 , see the generated
> hotspot/variant-server/gensrc/jfrfiles/jfrEventIds.hpp
>
> ```
>
> enum JfrEventId {
> JfrMetadataEvent = 0,
> JfrCheckpointEvent = 1,
> JfrDurationEvent = 2,
> JfrInstantEvent = 3,
> JfrValueEvent = 4,
> JfrTextEvent = 5,
> JfrZThreadDebugEvent = 6,
> .....
> JfrJavaAgentEvent = 161,
> JfrNativeAgentEvent = 162,
> JfrDeprecatedInvocationEvent = 163,
> };
> ```
>
> so NUMBER_OF_EVENTS + NUMBER_OF_RESERVED_EVENTS looks fine to me. 163 is the
> highest I could see while testing.
No, I am quite sure the `ev` substructure is wrong. The structure contains
members that are not events, that's why its larger.
But it's an issue orthogonal to the one you are fixing. I opened
https://bugs.openjdk.org/browse/JDK-8334031 to track it.
-------------
PR Comment: https://git.openjdk.org/jdk/pull/19628#issuecomment-2161205376
