On Wed, 12 Jun 2024 22:38:37 GMT, Zhao Song <zs...@openjdk.org> wrote:
> @kevinrushforth said in > [SKARA-2289](https://bugs.openjdk.org/browse/SKARA-2289), 'In general, our > repositories contain source code and not binary files. There are exceptions > to this for images and other similar resources, but otherwise the policy for > most repos is to avoid binary files'. Skara is able to identify binary files > when executing jcheck, but this check is not enabled. What I think we want here is an informational message for Reviewers rather than a warning. So a message in the Description that says something like "__Note__: this PR includes binary files" might be sufficient. I don't see the need to be more nuanced than that by checking the type of binary files. ------------- PR Comment: https://git.openjdk.org/jdk/pull/19683#issuecomment-2164217199
