On Mon, 24 Jun 2024 21:50:37 GMT, Calvin Cheung <cche...@openjdk.org> wrote:

>> More filtering is needed when building the default archive in the JDK: 
>> constant pool resolution when running the 
>> `build.tools.classlist.HelloClasslist` program is not deterministic (due to 
>> concurrency in core library classes). This could cause different values in 
>> the `@cp` lines in the classlist file. The benefit of pre-resolved constant 
>> pool entries is more visible for custom archives and not so much for the 
>> default archive in the JDK, so we disable this optimization for the default 
>> CDS archive, until we can find a way to make it deterministic.
>
> LGTM

Thanks @calvinccheung @dholmes-ora @tstuefe @erikj79 for the review.

-------------

PR Comment: https://git.openjdk.org/jdk/pull/19868#issuecomment-2189441564

Reply via email to