On Mon, 24 Jun 2024 20:23:30 GMT, Matias Saavedra Silva <matsa...@openjdk.org> wrote:
>> Ioi Lam has updated the pull request with a new target base due to a merge >> or a rebase. The incremental webrev excludes the unrelated changes brought >> in by the merge/rebase. The pull request contains four additional commits >> since the last revision: >> >> - Merge branch 'master' into 8309634-resolve-methods-at-dumptime >> - @calvinccheung and @matias9927 comments >> - Fixed whitespaces >> - 8309634: Resolve CONSTANT_MethodRef at CDS dump time > > src/hotspot/share/oops/cpCache.cpp line 454: > >> 452: >> 453: // Just for safety -- this should not happen, but do not archive if >> we ever see this. >> 454: resolved &= !(rme->is_resolved(Bytecodes::_invokehandle) || > > Don't forget to fix the whitespace problem here Fixed. ------------- PR Review Comment: https://git.openjdk.org/jdk/pull/19866#discussion_r1653862929
