On Wed, 22 May 2024 09:39:43 GMT, Hamlin Li <m...@openjdk.org> wrote:
>> make/devkit/createSleef.sh line 32: >> >>> 30: # >>> 31: # 1. cd <sleef> >>> 32: # 2. bash <jdk>/make/devkit/createSleef.sh aarch64-gcc.cmake >>> <path-to>/devkit >> >> So you'd need a different copy of sleef for each platform? The files you >> have put in `linux/native/libvectormath`, what platform are they for? Should >> we not put them in a platform-specific subdirectory? > >> So you'd need a different copy of sleef for each platform? > > I think it's one or more. > >> The files you have put in linux/native/libvectormath, what platform are they >> for? Should we not put them in a platform-specific subdirectory? > > we could, but not necessary, as long as they have different suffixes, and > normally that suffixes indicate what platform it's for. Okay, suffix works fine too. But the files currently in the patch is named e.g. `sleefinline_advsimd.h`, which does not indicate any platform at all. Is it a generic file, and the platform specific ones are still missing from this PR? ------------- PR Review Comment: https://git.openjdk.org/jdk/pull/19185#discussion_r1611448592
