On Fri, 30 Aug 2024 20:19:46 GMT, Erik Joelsson <er...@openjdk.org> wrote:
>> Magnus Ihse Bursie has updated the pull request incrementally with one >> additional commit since the last revision: >> >> Fix bad change in BuildMicrobenchmarks > > make/test/BuildMicrobenchmark.gmk line 71: > >> 69: # Need double \n to get new lines and no trailing spaces >> 70: MICROBENCHMARK_MANIFEST := Build: $(FULL_VERSION)\n \ >> 71: \nJMH-Version: $(JMH_VERSION)\n \ > > Are you sure these spaces are safe? The comment mentions trailing spaces as > something undesired and depending on how this is used, I suspect adding a > space between the \n could interfere with that. Now that I look at this again, I realize the broken lines start at position 1. That indicates that the original author did not want to indent the line as it "should" have been, just to make sure that no extra space were added. So you are likely correct; this was a bad change. Thanks for spotting it. ------------- PR Review Comment: https://git.openjdk.org/jdk/pull/20798#discussion_r1740197216
