On Thu, 5 Sep 2024 13:16:41 GMT, Erik Joelsson <er...@openjdk.org> wrote:

>> Debian "sid" or "unstable" (https://httpredir.debian.org/debian) that we use 
>> for debootstrapping RISC-V breaks very often. Currently, the GHA 
>> linux-cross-build for RISC-V would not continue and is simply skipped when 
>> this debootstrap for "sid" repos fails. (See 
>> [JDK-8326960](https://bugs.openjdk.org/browse/JDK-8326960) for more 
>> details). This is affecting GHA linux-cross-build for RISC-V for quite some 
>> time. As a result, we failed to catch some early build issues.
>> 
>> But I don't think we need to catch up with the latest Debian "unstable" for 
>> our GHA verification purpose. So one way would be using some older but 
>> working Debian shapshot [1] [2] for our purpose. I find the most recent 
>> usable shapshot is 
>> https://snapshot.debian.org/archive/debian/20240228T034848Z/. We can switch 
>> back to more stable Debian repo once it graduates.
>> 
>> [1] https://snapshot.debian.org/
>> [2] https://lists.debian.org/debian-snapshot/
>> 
>> Testing:
>> - [x] GHA
>
> Marked as reviewed by erikj (Reviewer).

> @erikj79 : Please take a look. Thanks.

> Maybe @erikj79 ? Thanks.

I generally skip most GHA related PRs as there are plenty of other reviewers on 
this mailing list with deeper GHA knowledge than I have, and it's not a focus 
for my current role at my employer. This patch was however small enough so I 
was comfortable approving it. 

Tagging me, or someone else, specifically in a PR, requesting a review with the 
intent of getting it quicker, will likely just have the opposite effect as it 
may deter other people from jumping in to review, thinking you already have 
some kind of agreement with the person being tagged.

-------------

PR Comment: https://git.openjdk.org/jdk/pull/20853#issuecomment-2331674850

Reply via email to