On Thu, 10 Oct 2024 18:11:23 GMT, Erik Joelsson <[email protected]> wrote:
>> Nizar Benalla has updated the pull request incrementally with one additional
>> commit since the last revision:
>>
>> typos - remove a few mentions of doccheck
>
> make/conf/jib-profiles.js line 1004:
>
>> 1002: var testOnlyProfilesPrebuiltDocs = clone(testOnlyProfilesPrebuilt);
>> 1003: testOnlyProfilesPrebuiltDocs["run-test-prebuilt-docs"] =
>> testOnlyProfilesPrebuiltDocs["run-test-prebuilt"];
>> 1004: delete testOnlyProfilesPrebuiltDocs["run-test-prebuilt"];
>
> I think this could be simplified to something like (untested):
> Suggestion:
>
> var testOnlyProfilesPrebuiltDocs = {};
> testOnlyProfilesPrebuiltDocs["run-test-prebuilt-docs"] =
> clone(testOnlyProfilesPrebuiltDocs["run-test-prebuilt"]);
This exact code didn't work, but I now have a more concise version
-------------
PR Review Comment: https://git.openjdk.org/jdk/pull/21272#discussion_r1796143631
