On Fri, 7 Mar 2025 07:21:43 GMT, David Holmes <[email protected]> wrote:
>> It's no that important, no. I'm not sure if previous deprecated ports were
>> handles exactly like this.
>>
>> And you can always do like `git log | grep -i "remove .* port"` to find the
>> change it was removed in, and look what it did...
>
> I think leaving a comment describing how to deprecate a port is useful. To
> look it up in history you have to realise there is something to look up.
>
> "They who are not reminded of the past will invent a new way to do it in the
> future."
The `--enable-deprecated-ports` is still there. All that is removed is an if
statement and a print line. I know the make syntax can seem intimidating, but
just ask me or any other build team member if you need help to recreate such a
thing. It is not like it is a complicated algorithm that can be written in many
ways. This is just make's equivalant of:
if (some_condition) {
println("whatever");
}
To me this is just utter nonsense to keep that commented out.
-------------
PR Review Comment: https://git.openjdk.org/jdk/pull/23906#discussion_r1985229429
