On Tue, 25 Mar 2025 08:49:34 GMT, Thomas Stuefe <stu...@openjdk.org> wrote:
> Why not just call bash with the script as argument? Or is this against some > policy or good style? EDIT: I didn't want to presume that the hook would necessarily be implemented as a shell script. It seems likely that it will almost always be the case, but forcing it feels unnecessarily restrictive. Requiring the script used for the hook to be executable didn't strike me as an unreasonable requirement, although I agree it should fail as quickly as possible if it weren't, which is why I added that check at configure time. But maybe I'm missing something; are you aware of a situation where this could prove problematic or overly annoying to the user? ------------- PR Comment: https://git.openjdk.org/jdk/pull/23807#issuecomment-2750573787
