On Mon, 7 Apr 2025 17:30:53 GMT, Alan Bateman <[email protected]> wrote:
>> Severin Gehwolf has updated the pull request incrementally with one
>> additional commit since the last revision:
>>
>> Review v2
>
> src/jdk.jlink/share/classes/jdk/tools/jlink/internal/LinkableRuntimeImage.java
> line 71:
>
>> 69: private static InputStream getDiffInputStream(String module) throws
>> IOException {
>> 70: String resourceName = String.format(DIFF_PATTERN, module);
>> 71: return JDK_JLINK_MOD.getResourceAsStream(resourceName);
>
> FYI you can use LinkableRuntimeImage.class.getResourceAsStream here as the
> resource is in the current module.
It's very odd, but when I attempt this then the resource is not found. It seems
to fail on the module name verification. For example: `jlink --help | tail -n2`
shows as `disabled` for an enabled linkable runtime image.
-------------
PR Review Comment: https://git.openjdk.org/jdk/pull/24388#discussion_r2033202346
